Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.29 CloudStack E2E tests #7549

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

abhay-krishna
Copy link
Member

Add Kubernetes v1.29 E2E tests for CloudStack provider.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 12, 2024
@abhay-krishna abhay-krishna force-pushed the 1.29-cloudstack-e2e branch 2 times, most recently from 01a32e8 to 68e4217 Compare February 12, 2024 10:29
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (d21aa39) 73.56%.
Report is 49 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 0.00% 5 Missing and 1 partial ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/clustermanager/cluster_manager.go 88.23% 2 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/workflows/workload/create_gitops.go 84.61% 2 Missing ⚠️
pkg/workflows/workload/post_delete.go 84.61% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 1 Missing ⚠️
cmd/eksctl-anywhere/cmd/validations.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7549      +/-   ##
==========================================
+ Coverage   73.48%   73.56%   +0.07%     
==========================================
  Files         579      580       +1     
  Lines       36357    36505     +148     
==========================================
+ Hits        26718    26854     +136     
- Misses       7875     7888      +13     
+ Partials     1764     1763       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxbrowne1207
Copy link
Member

cxbrowne1207 commented Feb 13, 2024

Can you update the tests in the quick e2e suite as well?

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/retest

@eks-distro-bot eks-distro-bot merged commit f97684d into aws:main Feb 13, 2024
11 checks passed
@abhay-krishna abhay-krishna deleted the 1.29-cloudstack-e2e branch March 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants